On Thu, Apr 25, 2013 at 01:39:44PM +0800, Osier Yang wrote:
> On 25/04/13 13:06, Amos Kong wrote:
> >Libvirt has no way to probe if an option or property is supported,
> >This patch introdues a new qmp command to query command line
> >option information. hmp command isn't added because it's not needed.
> >
> >Signed-off-by: Amos Kong <ak...@redhat.com>
> >CC: Osier Yang <jy...@redhat.com>
> >CC: Anthony Liguori <aligu...@us.ibm.com>
> >---
> >V3: fix jaso schema and comments (Eric)
>
> s/jaso/json/,
>
> >V4: fix descriptions, rename command, check enum type, cleanup
> >---
> > qapi-schema.json | 66
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++
> > qmp-commands.hx | 48 ++++++++++++++++++++++++++++++++++++++
> > util/qemu-config.c | 68
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 182 insertions(+)
...
> >+{'command': 'query-command-line-options', 'data': { '*option': 'str' },
> >+ 'returns': ['CommandLineOptionInfo']}
> >diff --git a/qmp-commands.hx b/qmp-commands.hx
> >index 4d65422..77fe443 100644
> >--- a/qmp-commands.hx
> >+++ b/qmp-commands.hx
> >@@ -2416,6 +2416,54 @@ EQMP
> > },
> > SQMP
> >+query-command-line-options
> >+--------------------------
> >+
> >+Show command line option schema.
> >+
> >+Return a jaso-array of command line option schema for all options (or for
>
> s/jaso-array/json-array/,
>
> >+the given option), returning an error if the given option doesn't exist.
> >+
> >+Each array entry contains the following:
> >+
> >+- "option": option name (json-string)
> >+- "parameters": an array of json-objects, each describing one
> >+ parameter of the option:
>
> To be consistent, s/an array of json-objects/a json-array/,
>
> How about:
>
> a json-array describes parameters of the option
I will change it to:
"parameters": a json-array describes all parameters of the option:
>
> >+ - "name": parameter name (json-string)
> >+ - "type": parameter type (one of 'string', boolean', 'number',
> >+ or 'size')
> >+ - "help": human readable description of the parameter
> >+ (json-string, optional)
> >+
> >+
--
Amos.
