Re: [Qemu-devel] [PATCH v2 01/12] qemu-img: introduce qemu_img_handle_error()

[Wenchao Xia]

于 2013-4-25 0:44, Eric Blake 写道:

On 04/24/2013 09:31 AM, Pavel Hrdina wrote:

Later in the patch series we will use this function a few times.
This will avoid duplicating the code.

Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
---
  qemu-img.c | 17 +++++++++++------
  1 file changed, 11 insertions(+), 6 deletions(-)

+static int qemu_img_handle_error(Error *err)
+{
+    if (error_is_set(&err)) {
+        error_report("%s", error_get_pretty(err));
+        error_free(err);
+        return 1;
+    }
+    return 0;

Maybe it's just me, but I think returning EXIT_SUCCESS/EXIT_FAILURE
instead of 0/1 is a bit nicer at expressing why we chose a positive
value; but that would be a separate cleanup to all of qemu-img.c.
Hence, I have no problems giving:

Reviewed-by: Eric Blake <ebl...@redhat.com>

  Maybe an incode comments like:
+/* Returns 1 on error. */

Reviewed-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>

--
Best Regards

Wenchao Xia