On 04/23/2013 02:26 PM, Anthony Liguori wrote:
"Michael R. Hines" <mrhi...@linux.vnet.ibm.com> writes:
On 04/23/2013 01:50 PM, Anthony Liguori wrote:
mrhi...@linux.vnet.ibm.com writes:
From: "Michael R. Hines" <mrhi...@us.ibm.com>
Juan, Please pull.
I assume this is actually v6, not v5?
I don't see collected Reviewed-bys...
That said, we're pretty close to hard freeze. I think this should wait
until 1.6 opens up although I'm open to suggestion if people think this
is low risk. I don't like the idea of adding a new protocol this close
to the end of a cycle.
Regards,
Anthony Liguori
There are no instructions/procedures documented on the qemu.org
website on how to automatically generate "Reviewed-by" signatures.
I suspect there's some confusion here. Addressed review comments !=
Reviewed-by. There can always be additional comments. Someone has to
explicitly offer a Reviewed-by indicating that they are happy with the
patches overall. I've gone through the history on these patches and I
don't see any explicit Reviewed-by's other than Eric's most recent one.
Give the series a little more time for people to look over it, it'll get
Reviewed-bys when people are ready to offer them.
Ah, OK, so then when I receive the signatures by email, do
I just literally "paste" the Reviewed-By directly into the patch series
by hand?
Is this not handled by git?
- Michael
