On (Tue) Oct 20 2009 [10:56:40], Gerd Hoffmann wrote:
> Hi,
>
>> This patch series fixes a few problems since the last send, mainly in
>> the save/restore code and a few bugs shown by the automated test suite
>> (located in a separate git repo, link below).
>
> A bit hard to review in this form, especially the virtio-console.c
> changes, because you put everything upside down in that file. Hard to
> do better though given the massive code reorganization ...
Top-down is the usual way of writing code, isn't it (avoids fwd
declarations too).
Also, I've arranged the code according to some grouping: functions
useful to outside users first, then functions using some outside
facilities, and then intialisation functions.
> So I applied the bits and looked at the resulting tree instead. Looks
> good overall, just a few minor nits, check the replies to the individual
> patches. I think we are ready to go as soon as the linux kernel side is
> on the way to mainline.
Yeah; waiting for Rusty's comments.
Amit
