On 04/15/13 23:11, Eric Blake wrote: > On 04/15/2013 02:47 PM, Laszlo Ersek wrote: >> This patch reuses some code from SeaBIOS, which was originally under >> LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This >> relicensing has been acked by all contributors that had contributed to the >> code since the v2->v3 relicense. ACKs approving the v2+ relicensing are >> listed below. The list might include ACKs from people not holding >> copyright on any parts of the reused code, but it's better to err on the >> side of caution and include them. >> > ... > > Thanks for tracking that down.
The credits belong to Michael. >> Changes since v1, based on prototype code from Michael Tsirkin: >> - "hw/i386/pc.c" is too big, create new file "hw/i386/acpi.c" with >> i386-specific ACPI table stuff, >> - separate preparation of individual tables from their installation as >> fw_cfg files, >> - install these fw_cfg files inside pc_memory_init(), which is shared by >> piix4/q35, >> - add the above licensing-related block to the commit message. > > This paragraph of information usually appears... > >> >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >> --- > > ...here, so someone doing 'git am' on the message doesn't include > information that is essential to the review process, but worthless to > the ultimate git history (readers of 'git log' don't care how many > iterations a patch took before it was ready to be included). I'm aware and agree in general; on this occasion I left it in on purpose. The v1->v2 changes are somewhat relevant on their own IMHO, plus I wanted to save for posterity that v2 of this patch has been greatly influenced by a patch Michael sent me in private. If you think it's important I can respin and mayhap reword. > Sorry - I just did a superficial review of the commit message, but this > is in code that I'm not familiar enough with to do any sort of formal > review. Thank you very much for the review! I can't imagine where you got the energy from to look at random patches on the list. Laszlo
