On 04/10/2013 04:28 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" <mrhi...@us.ibm.com> > > This allows the user to disable zero page checking during migration > > Signed-off-by: Michael R. Hines <mrhi...@us.ibm.com> > ---
> +++ b/qapi-schema.json
> @@ -1792,6 +1792,19 @@
> { 'command': 'migrate_set_downtime', 'data': {'value': 'number'} }
>
> ##
> +# @migrate_check_for_zero
> +#
> +# Control whether or not to check for zero pages during migration.
New QMP commands should be named with '-' rather than '_', as in
'migrate-check-for-zero'.
Why do we need a new command, instead of adding a new capability to the
already-existing capability command?
> +#
> +# @value: on|off
> +#
> +# Returns: nothing on success
> +#
> +# Since: 1.5.0
> +##
> +{ 'command': 'migrate_check_for_zero', 'data': {'value': 'bool'} }
You can set the capability, but how do you query its current setting? I
dislike write-only interfaces.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
