On Tue, Apr 09, 2013 at 08:37:16PM -0400, Kevin O'Connor wrote: > On Tue, Apr 02, 2013 at 12:07:46PM +0300, Gleb Natapov wrote: > > On Mon, Apr 01, 2013 at 08:22:57PM -0400, Kevin O'Connor wrote: > > > On Sun, Mar 31, 2013 at 05:34:10PM +0300, Gleb Natapov wrote: > > > > On Sat, Mar 30, 2013 at 09:20:09AM -0400, Kevin O'Connor wrote: > > > > The patch uses existing channel between qemu and seabios, one > > > > romfile_loadint() is all it takes. We already have number of interfaces > > > > to change OS visible ACPI tables, that's why we want to move ACPI table > > > > creation to QEMU in the first place. It is unfortunate to start blocking > > > > features now before we have an alternative. When ACPI table creation > > > > will move into QEMU the code in this patch will be dropped along with > > > > all the other code that serves similar purpose. > > > > > > If there is a general consensus that this feature is important then > > > we'll go forward with adding it as is. To be clear though, my > > > preference would be to go forward with moving ACPI tables into QEMU, > > > and then add this stuff on top of that. If no one beats me to it, > > > I'll send some initial patches myself. > > > > > If we can accomplish the move before next major QEMU release we do not > > need this new fw_cfg file obviously. Paolo thinks this is not feasible, > > I haven't followed this work to close to have informed opinion. > > I was hoping I'd get a chance to submit some QEMU patches for this > before the soft-freeze, but unfortunately I have not been able to. > Since I don't want to hold up features, I remove my earlier objection > and I'm okay with committing this to SeaBIOS.
Glad to hear that! > > Hu Tao - if the QEMU part of the pvpanic series is committed to QEMU > I'll commit the corresponding SeaBIOS parts. Thanks a lot! -- Regards, Hu Tao
