Pavel Hrdina <phrd...@redhat.com> writes: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> [...] > diff --git a/block/rbd.c b/block/rbd.c > index 1a8ea6d..cdbee18 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -816,12 +816,14 @@ static int qemu_rbd_truncate(BlockDriverState *bs, > int64_t offset) > } > > static int qemu_rbd_snap_create(BlockDriverState *bs, > - QEMUSnapshotInfo *sn_info) > + QEMUSnapshotInfo *sn_info, > + Error **errp) > { > BDRVRBDState *s = bs->opaque; > int r; > > if (sn_info->name[0] == '\0') { > + error_setg(errp, "parameter 'name' cannot be empty"); > return -EINVAL; /* we need a name for rbd snapshots */ > } >
Comment is now redundant. Drop it if you need to respin anyway. [...]