Paolo Bonzini <pbonz...@redhat.com> wrote:
> The same QEMUFile is never used for both read and write.  Simplify
> the logic to simply look for presence or absence of the right ops.
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>

Love this one.

> @@ -556,11 +557,7 @@ static void qemu_fill_buffer(QEMUFile *f)
>      int len;
>      int pending;
>  
> -    if (!f->ops->get_buffer)
> -        return;

Why are we removing this test?  this has nothing to do with the is_write
removal?
And yes,  having a better way of knowing that the operations are there
looks like a good idea,  but that is independent of this series.


Thanks,  Juan.

Reply via email to