Hi, Kevin Except the comments from Eric for better code comments, do you think other things need improved? Modified patches is addressed as following, I hope fix all in next version, to avoid using more time of reviewer.
> > v11: > General change: > 5/17: check if snapshot > 0 on success in caller, add comments on the > function says that caller need to check it on success. > 7/17: check if snapshot > 0 on success before set info->has_snapshots. > > Address Eric's comments: > 5/17: use error_setg_errno instead of strerror(). > 12/17: also move bdrv_snapshot_dump() since it need to be changed using > GString later. > 13/17: using GString as buffer. > 14/17: using GString to dump snapshot info. > 16/17: using GString to dump image info. > > Address Kevin's comments: > 11/17: return void for bdrv_query_info(). > 17/17: spell fix in help message, using parameter "-v" to show > verbose info. > -- Best Regards Wenchao Xia
