On 4 April 2013 15:04, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 04/04/2013 15:56, Peter Maydell ha scritto: >> I think this define should go in an include file in >> linux-user/m68k/ -- it's ABI specific and we should >> be aiming to isolate ABI specific info in linux-user/ >> rather than having it leaking into target-* and thus >> into the system emulation code. >> >> Otherwise patch looks good. > > That would create 10 empty files, and two files between one and three > lines of code. I would just put those in include/exec/user/abitypes.h.
I would prefer not to add more code with TARGET ifdefs. (I have a vague plan to split up some of the current linux-user code which is #ifdefs in source files in linux-user into per target source files which make just pulls in as appropriate.) Also, separate files in linux-user/foo encourage authors of new targets to think "do I need to put something in my new target's version of this?" whereas #ifdef TARGET_FOO in common source files don't. Riku's the linux-user maintainer, though... thanks -- PMM
