Richard Jones <rjo...@redhat.com> reported that BDRV_O_SNAPSHOT does not work with NBD:
/usr/bin/qemu-system-x86_64 \ [...] -device virtio-scsi-pci,id=scsi \ -drive file=nbd:localhost:61930,snapshot=on,format=raw,id=hd0,if=none \ -device scsi-hd,drive=hd0 \ [...] gives the error: qemu-system-x86_64: -drive file=nbd:localhost:61930,snapshot=on,format=raw,id=hd0,if=none: could not open disk image nbd:localhost:61930: No such file or directory This series fixes the issue and adds a regression test, qemu-iotests 052. Run the test like this: $ QEMU_PROG=... PATH=... ./check -nbd 052 If Patch 1 is not applied, the test case fails. Note that the test case is also useful with -raw or other formats. Stefan Hajnoczi (2): block: fix BDRV_O_SNAPSHOT protocol detection qemu-iotests: add 052 BDRV_O_SNAPSHOT test block.c | 9 +++---- tests/qemu-iotests/052 | 61 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/052.out | 13 ++++++++++ tests/qemu-iotests/group | 1 + 4 files changed, 78 insertions(+), 6 deletions(-) create mode 100755 tests/qemu-iotests/052 create mode 100644 tests/qemu-iotests/052.out -- 1.8.1.4