On Thu, Mar 14, 2013 at 01:13:54PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" <m...@redhat.com> writes: > [...] > >> > diff --git a/qapi-schema.json b/qapi-schema.json > >> > index 28b070f..bb361e1 100644 > >> > --- a/qapi-schema.json > >> > +++ b/qapi-schema.json > >> > @@ -2354,7 +2354,9 @@ > >> > # Notes: When this command completes, the device may not be removed > >> > from the > >> > # guest. Hot removal is an operation that requires guest > >> > cooperation. > >> > # This command merely requests that the guest begin the hot > >> > removal > >> > -# process. > >> > +# process. Completion of the device removal process is signaled > >> > with a > >> > +# DEVICE_DELETED event. Guest reset will automatically complete > >> > removal > >> > +# for all devices. > >> > # > >> > # Since: 0.14.0 > >> > ## > >> > >> What do you mean by "Guest reset will automatically complete removal for > >> all devices"? > > > > Just this. Try this: rmmod acpiphp in guest, then: > > > > device_del > > system_reset > > > > and see the device disappear even though it was not acked by guest. > > Cool, I didn't know that. > > Just to make sure: does this automatic removal completion send > DEVICE_DELETED events?
With my patch, it does.
