On Wed, 13 Feb 2008, Daniel Jacobowitz wrote: > On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote: > > if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) && > > !ctx->singlestep_enabled) { > > .. > > } else { > > gen_set_T1(dest); > > #if defined(TARGET_PPC64) > > if (ctx->sf_mode) > > gen_op_b_T1_64(); > > else > > #endif > > gen_op_b_T1(); > > if (ctx->singlestep_enabled) > > gen_op_debug() > > } > > > > It seems to me that the second if (ctx->singlestep_enabled) is > > rendundant. > > No, if you've gone to a different page without single step then you > don't need the debug trap.
Hm, so you mean betweeen the first "if .. !ctx->singlestep_enabled" and the second one in the evaluation of ctx->singlestep_enabled changes? What I meant is simply that the "else" clause already implies that ctx->singlestep_enabled is true. Regards Marius -- Marius Groeger SYSGO AG Embedded and Real-Time Software Voice: +49 6136 9948 0 FAX: +49 6136 9948 10 www.sysgo.com | www.elinos.com | www.osek.de | www.pikeos.com