Re: [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info()

[Wenchao Xia]

于 2013-3-9 4:34, Eric Blake 写道:

On 03/06/2013 11:07 PM, Wenchao Xia wrote:

   Parameter *fmt was not used, so remove it.

Reviewed-by: Eric Blake <ebl...@redhat.com>

Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>

Typically, these annotations should be kept in chronological order.
That is, the first line should always be a Signed-off-by (you have to
write a patch before anyone else can add their Reviewed-by).  Also, we
tend to avoid blank lines in the attribution section.  So, the preferred
way to write this would be:

Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>

But that's cosmetic, and my review still stands.

OK.

--
Best Regards

Wenchao Xia