> On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>>    This file will have internal snapshot related functions.
>>
>> Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
>> ---
> 
>> --- /dev/null
>> +++ b/include/block/snapshot.h
>> @@ -0,0 +1,4 @@
>> +#ifndef SNAPSHOT_H
> 
> Introducing a new file without a copyright notice is a no-no.
> 

  Copy right is notice in snapshot.c, other header files seems
no copy right declaration, what more should be added?

-- 
Best Regards

Wenchao Xia


Reply via email to