On 03/04/2013 06:10 AM, Stefan Hajnoczi wrote: >>> It is also useful to include QMP examples or the QMP docs in the cover >>> letter so reviewers know what you are trying to achieve. >>> >> OK, a better explaination would be added in the cover-letter. > > Thanks. When reviewers don't know your goal at the start of their > review, they may object to things that make sense at the end of the > series because they do not have enough context yet. A series where the > goal is unclear also risks a higher number of review-fix cycles because > the reviewers haven't bought into the idea yet. > > It is in everyone's interest to explain the goal in the cover letter. > Then the patches get reviewed more smoothly and merged faster.
This is good advice - so good that I added it to the wiki: http://wiki.qemu.org/Contribute/SubmitAPatch > > This is a general thought I wanted to share and I struggle with it > myself sometimes when I submit patch series. Me too - but the nice thing about open source is that we can all learn best practices from one another and become better at it :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
