On (Fri) 01 Mar 2013 [10:51:33], Paolo Bonzini wrote:
> Il 01/03/2013 01:36, Eric Blake ha scritto:
> > For fd passing to work, we have to use qemu_open() instead of raw
> > open(). Is there any way to enforce that all files being opened by qemu
> > go through the appropriate qemu_open() wrapper?
> >
> > Meanwhile, we have a quandary on the libvirt side of things: qemu 1.4
> > supports fd passing in general, but does not support it for rng. I
> > guess the same is true for -blockdev - we don't (yet) have a way to do
> > fd passing for backing files. Do we need some sort of QMP command that
> > will let libvirt query for a particular device whether that device is
> > known to support fd passing, so that libvirt can use fd passing for all
> > supported devices, while falling back to older direct open()s, and to
> > know which instance of qemu can safely have open() blocked at the
> > SELinux or syscall blacklist level?
>
> Let's change open to qemu_open for 1.4.1, and declare rng only supported
> in 1.4.1...
In addition, we can tweak checkpatch.pl to flag such usage as a warning.
Amit
