Re: [Qemu-devel] [PATCH V6 04/14] block: move collect_snapshots() and collect_image_info() to block.c

[Wenchao Xia]

于 2013-2-20 5:24, Eric Blake 写道:

On 02/18/2013 07:09 AM, Wenchao Xia wrote:

Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
---
  block.c               |   81 +++++++++++++++++++++++++++++++++++++++++++++++++
  include/block/block.h |    4 ++
  qemu-img.c            |   81 -------------------------------------------------
  3 files changed, 85 insertions(+), 81 deletions(-)

+++ b/include/block/block.h
@@ -450,4 +450,8 @@ int bdrv_debug_breakpoint(BlockDriverState *bs, const char 
*event,
  int bdrv_debug_resume(BlockDriverState *bs, const char *tag);
  bool bdrv_debug_is_suspended(BlockDriverState *bs, const char *tag);

+void collect_snapshots(BlockDriverState *bs , ImageInfo *info);
+void collect_image_info(BlockDriverState *bs,
+                        ImageInfo *info,
+                        const char *filename);

As part of making these functions public, shouldn't you fix them to live
in the right space?  Everything else in this .h starts with bdrv_ for a
reason.

  This patch is just for making review easier, those two functions will
be deleted later so they do not have much meaning, renaming may bring
confusion to reviewer.


--
Best Regards

Wenchao Xia