-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 23.02.2013 15:02, schrieb Jan Kiszka: > On 2013-02-23 14:12, Andreas Färber wrote: >> Am 22.02.2013 21:39, schrieb Jan Kiszka: >>> Rebased over current master, resolved new reports of >>> checkpatch. >> >> This doesn't really take all developments in master into >> account, comments on 2/2. > > Yeah, that happens if such patches wait too long for being applied > (3 months). Will address the QOM changes, but I need to check back > with $customer regarding test suite efforts.
Thanks. My concern here is in particular that this device is not added to any machine, so it gets no implicit testing. Nor does the commit message or cover letter specify with which command line and guest it has been tested. Whether all code paths actually get test coverage is less relevant to me than a smoke test to assure my QOM refactorings don't break anything. :) Cheers, Andreas - -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRKM1xAAoJEPou0S0+fgE/VSsP/36YyY9BhSxpv6kN+AC8g4ed sR7IgV5Pte3S6CaAifB1ici5CHEOOHYXlr3Q+Qp3bsDABaZS7CU1TcFmJLlK7aN6 dzh4tIYg45K/M/QzjB4qwchsYEEz8vWSU98etW/yWU/7VTL9TS4DIxj4B09fgJRj +cmuKNdvHd3irX6kFxVmLW/eqyzcBPVXMr2U9ZidAqS4TZZ0SOHhUYwLzpFa6QV/ +1oLBjNhlWTn/a4pzCifilGmNHwheQnaXTtlYKVsuI6BhvkDLGHezRnzZirhzJnF RQAk+KRB/cBCAhbIJJ1sAjgmTUs7HZVS1Jy9eH6+LUvSPVqO82R5Hj+AsF9bgRL6 mjae3vkqhowgu39kDZQoJ5bn6GOHNQAZ/ggYlsYZxvhp4ToN95cpP5amTIOeN6nG fmopmzEaHEYSSInO/+/tZAp6NGePyBLtpAb6iYxM0ZXewZ6QpbtTlPHyzhpkZMYM 2PHHFhqSwzUy4Vo9ZjQ6WY5Mp0Mal14xaKfHQvqwnMySh8k7fIKQSrJXSkh5rJ7e +UQBdnp5QhiyfB6rEzY9hTUhrxQNhvaTbUzHeUH1Ii4FEC422ce3eqDbJBL0kNaA RYjrZi4KsOdb7s6BPyq/0jAOwc0y52RlkwwPtJQAh9+vVO0wpx8GBKcTMQyLFiIt YIfelNvAB4ZN2q3P6Vxp =ruQu -----END PGP SIGNATURE-----
