On 22 February 2013 21:15, Paul Brook <p...@codesourcery.com> wrote: >> @@ -100,6 +102,7 @@ struct CPUState { >> bool stop; >> bool stopped; >> volatile sig_atomic_t exit_request; >> + volatile sig_atomic_t tcg_exit_req; > > Do we really need annother variable/check? It seems like this should be at > least partially redundant with the existing icount code. I have a simialr > patch to that effect.
I wanted to keep the code simple and easy to review for correctness and obvious non-interaction with other features. (My first patch along these lines tried to reuse exit_request, but this hangs Linux in SMP in system mode, for instance.) -- PMM