Paolo Bonzini <pbonz...@redhat.com> wrote: > This is useful, because it lets us keep the cancellation callbacks > inside the big lock while pushing the others out. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Juan Quintela <quint...@redhat.com> If we need to rebase: > ret = qemu_file_get_error(f); > - if (ret != 0) { > - qemu_savevm_state_cancel(); > - } > - > return ret; return qemu_file_get_error(f); looks better than: ret = qemu_file_get_error(f); return ret; IMHO O:-) > - > } > > /* > @@ -1677,9 +1671,6 @@ int qemu_savevm_state_iterate(QEMUFile *f) > return ret; > } > ret = qemu_file_get_error(f); > - if (ret != 0) { > - qemu_savevm_state_cancel(); > - } > return ret; Same here