On 19 February 2013 17:44, Igor Mitsyanko <i.mitsya...@samsung.com> wrote: > On 02/19/2013 11:46 AM, Peter Crosthwaite wrote: >> >> Device model for Primecell PL330 DMA controller. >> >> Signed-off-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> >> Signed-off-by: Kirill Batuzov <batuz...@ispras.ru> >> Tested-by: Igor Mitsyanko <i.mitsya...@samsung.com> > > > Is my reviewed-by required if it already has my tested-by? I have a few > minor comments bellow and then you can add my reviewed-by tag if you want.
They mean different things (both worth noting): Tested-by means you ran the code and it did the right thing Reviewed-by means you read the code and it looks good -- PMM
