Re: [Qemu-devel] [PATCH 19/41] migration: reorder SaveVMHandlers members

[Orit Wasserman]

On 02/15/2013 07:46 PM, Paolo Bonzini wrote:
> This groups together the callbacks that later will have similar
> locking rules.
> 
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
>  include/migration/vmstate.h |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index f27276c..6229569 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -32,13 +32,15 @@ typedef int LoadStateHandler(QEMUFile *f, void *opaque, 
> int version_id);
>  typedef struct SaveVMHandlers {
>      void (*set_params)(const MigrationParams *params, void * opaque);
>      SaveStateHandler *save_state;
> +
>      int (*save_live_setup)(QEMUFile *f, void *opaque);
> -    int (*save_live_iterate)(QEMUFile *f, void *opaque);
> +    void (*cancel)(void *opaque);
>      int (*save_live_complete)(QEMUFile *f, void *opaque);
> +    bool (*is_active)(void *opaque);
> +    int (*save_live_iterate)(QEMUFile *f, void *opaque);
>      uint64_t (*save_live_pending)(QEMUFile *f, void *opaque, uint64_t 
> max_size);
> -    void (*cancel)(void *opaque);
> +
>      LoadStateHandler *load_state;
> -    bool (*is_active)(void *opaque);
>  } SaveVMHandlers;
>  
>  int register_savevm(DeviceState *dev,
> 
Reviewed-by: Orit Wasserman <owass...@redhat.com>