On 02/16/2013 05:56 AM, Andreas Färber wrote:
Am 15.02.2013 20:39, schrieb Stefan Berger:
diff --git a/tpm/tpm_tis.c b/tpm/tpm_tis.c
new file mode 100644
index 0000000..565e28d
--- /dev/null
+++ b/tpm/tpm_tis.c
[...]
+/*
+ * This function is called when the machine starts, resets or due to
+ * S3 resume.
+ */
+static void tpm_tis_reset(DeviceState *d)
+{
+    TPMState *s = DO_UPCAST(TPMState, busdev.qdev, d);
Please introduce a QOM cast macro in tpm_int.h (e.g., TPM_TIS() or
TPM(), preferably in this patch for better review) and use that instead
of DO_UPCAST().

Ok, this and the rest I fixed for the next version.

   Stefan


Reply via email to