On Tue, Feb 12, 2013 at 05:33:30PM +0000, Peter Maydell wrote: > Switch the default for qemu_log logging output from "/tmp/qemu.log" > to stderr. This is an incompatible change in some sense, but logging > is mostly used for debugging purposes so it shouldn't affect production > use. The previous behaviour can be obtained by adding "-D /tmp/qemu.log" > to the command line. > > This change requires us to: > * update all the documentation/help text > * make linux-user and bsd-user defer to qemu-log for the default > logging destination rather than overriding it themselves > * ensure that all logfile closing is done via qemu_log_close() > and that that function doesn't close stderr > as well as the obvious change to the behaviour of do_qemu_set_log() > when no logfile name has been specified. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Stefan suggested that qemu_log should default to stderr, and I > agree that it makes more sense than a random file in /tmp/. > As noted in the commit message, this is technically an incompatible > change. > > This patchset sits on top of my recent 6 patch qemu_log > cleanup series. > > bsd-user/main.c | 15 +++++++-------- > hmp-commands.hx | 4 ++-- > include/qemu/log.h | 8 ++++++-- > linux-user/main.c | 14 ++++---------- > qemu-doc.texi | 8 ++++---- > qemu-log.c | 29 +++++++++++------------------ > qemu-options.hx | 10 +++++----- > tcg/tci/README | 2 +- > 8 files changed, 40 insertions(+), 50 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
