On 11 February 2013 17:56, Richard Henderson <r...@twiddle.net> wrote: > On 2013-02-11 09:44, Peter Maydell wrote: >> Maybe clearer to pull out the "#if HOST_LONG_BITS == 64" into >> its own #if rather than having it as an && term in both the #if >> and the #elif? > > > In which case you get two "base" (unsigned long reserved_va;) cases, which > didn't look clearer at all. The only other thing I can think to do is > > #if HLB == 64 > # if MIPS > # define RESERVED_MAX 0x7f000000 > # elif TLB == 32 > # define RESERVED_MAX 0xf7000000 > # endif > #endif > #ifndef RESERVED_MAX > # define RESERVED_MAX 0 > #endif > > unsigned long reserved_va = RESERVED_MAX;
I think that does look better. As I say, I don't feel very strongly though. -- PMM
