> Am 29.01.2013 10:23, schrieb Guan Xuetao: >>> -----���浠跺��浠�----- >>> ���浠朵��: Andreas F盲rber [mailto:afaer...@suse.de] >>> ��������堕��: Sunday, January 27, 2013 21:32 >>> ��朵欢浜�: qemu-devel@nongnu.org >>> ������: Andreas F盲rber; Guan Xuetao (maintainer:UniCore32) >>> 涓婚��: [RFC 19/19] target-unicore32: Refactor debug output macros >>> >>> Make debug output compile-testable even if disabled. >>> >>> Signed-off-by: Andreas F盲rber <afaer...@suse.de> >> >> The patch could work, but I don't think it's a good idea. > > Yes, I agree. The plan for v2 is to use static inline functions and to > keep using #ifdef rather than #if. > >> Perhaps tracetools can be better. > > Tracepoints are not as flexible as they require a fixed set of up to > 6(?) arguments. But yes, if you were to replace these macros in > unicore32 code with specific tracepoints that would solve the issue at > hand as well and would even allow to enable/disable them at runtime. Tracepoints, or tracetools? As tracetools, it's unneccessary to have fixed 6 arguments. In my recent development on unicore64, all debug information is output by tracetools, and it's very convenient. I hope to reform unicore32 by this means.
> > CC'ing some more people on this new input. Maybe there would be a common > subset of tracepoints? Anthony mentioned LOG_EXCP and LOG_DIS; would not > only the names but also the arguments be generalizable? I haven't learned about tracepoints and LOG_*. I will put it on my TODO list. Thanks, Xuetao > > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N眉rnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend枚rffer; HRB 16746 AG N眉rnberg >
