Am 05.02.2013 01:07, schrieb Peter Maydell: > On 4 February 2013 23:52, Richard Henderson <r...@twiddle.net> wrote: >> On 2013-02-04 15:30, David Gibson wrote: >>> Anthony, Richard, anyone? >>> >>> Please apply - qemu has now been build-broken on all big endian >>> platforms for a month. >> >> >> I know. See also my bswap.h patch which also fixes the width >> of long vs uintptr_t. No one seems willing to pick these up... > > In both cases, the patch: > * was sent out after the soft freeze > * doesn't have a "for-1.4" tag > * doesn't have a summary line that clearly says "fixes build > failure" either > * hasn't got a Reviewed-by: tag from anybody
I ack'ed it, which in my terminology usually means that I reviewed and tested it. > > so I'm not terribly surprised they haven't got picked up. > You could start by reviewing each others' patches :-) Personally I see no reason to keep around misnamed HOST_LONG_BITS at all when we can easily calculate its value using sizeof(uintptr_t) * 8 or replace it by different conditions as suggested by rth. I thus prefer his patch and have been waiting for Blue to pick it up for 1.4. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
