Johannes Schindelin wrote: > Hi, > > On Thu, 17 Jan 2008, Alexander Graf wrote: > > >> This patch is mostly a cleanup of Michael Matz's patch with the ideas >> that came last time included. >> > > Maybe the patch subject could be "prepare i386 host for gcc4, step 1)? > >
Basically it fixes it, just not completely ;-). >> Index: qemu/softmmu_header.h >> =================================================================== >> --- qemu.orig/softmmu_header.h >> +++ qemu/softmmu_header.h >> @@ -189,9 +189,11 @@ static inline void glue(glue(st, SUFFIX) >> #else >> #error unsupported size >> #endif >> + "pushl %%ecx\n" >> "pushl %6\n" >> "call %7\n" >> "popl %%eax\n" >> + "popl %%ecx\n" >> > > Could you guard this so that this code is only included for gcc4? (I am > assuming that it is not needed for gcc3, as it worked so far...) > > You're right on that one. Thanks for the catch.
