Anders Melchiorsen <[EMAIL PROTECTED]> writes:
> --- a/qemu/vl.c
> +++ b/qemu/vl.c
> @@ -4902,13 +4902,6 @@ static void dumb_resize(DisplayState *ds, int w, int h)
> {
> }
>
> -static void dumb_refresh(DisplayState *ds)
> -{
> -#if defined(CONFIG_SDL)
> - vga_hw_update();
> -#endif
> -}
> -
> static void dumb_display_init(DisplayState *ds)
> {
> ds->data = NULL;
> @@ -4916,7 +4909,7 @@ static void dumb_display_init(DisplayState *ds)
> ds->depth = 0;
> ds->dpy_update = dumb_update;
> ds->dpy_resize = dumb_resize;
> - ds->dpy_refresh = dumb_refresh;
> + ds->dpy_refresh = NULL;
> }
Hi again.
My understanding is that the vga_hw_update() call pushes VRAM contents
into whatever ->data buffer the display (SDL, VNC, etc.) has provided,
and calls ->dpy_update() to have it shown. As the dumb driver has no
data area, this is not needed.
The ->dpy_refresh pointer can safely be NULL, as it is only called
from gui_update(). The gui_update() function is a timer callback that
is only set up if the ->dpy_refresh value is indeed non-NULL.
All the removed code was added in this patch,
http://www.mail-archive.com/qemu-devel@nongnu.org/msg10829.html
Stefan, can you maybe confirm that this part of your patch is in fact
not needed?
Cheers,
Anders.
