On Thu, Jan 24, 2013 at 11:46:28AM +0100, Peter Lieven wrote: > > Am 24.01.2013 um 11:41 schrieb Andreas Färber <afaer...@suse.de>: > > > Am 24.01.2013 11:32, schrieb Markus Armbruster: > >> Peter Lieven <p...@dlhnet.de> writes: > >> > >>> Latest git doesn't compile with this patch: > >>> > >>> hw/fw_cfg.c: In function 'fw_cfg_write': > >>> hw/fw_cfg.c:207:5: error: implicit declaration of function > >>> trace_fw_cfg_write' [-Werror=implicit-function-declaration] > >>> hw/fw_cfg.c:207:5: error: nested extern declaration of > >>> trace_fw_cfg_write' [-Werror=nested-externs] > >>> hw/fw_cfg.c: In function 'fw_cfg_select': > >>> hw/fw_cfg.c:232:5: error: implicit declaration of function > >>> trace_fw_cfg_select' [-Werror=implicit-function-declaration] > >>> hw/fw_cfg.c:232:5: error: nested extern declaration of > >>> trace_fw_cfg_select' [-Werror=nested-externs] > >>> hw/fw_cfg.c: In function 'fw_cfg_read': > >>> hw/fw_cfg.c:247:5: error: implicit declaration of function > >>> trace_fw_cfg_read' [-Werror=implicit-function-declaration] > >>> hw/fw_cfg.c:247:5: error: nested extern declaration of > >>> trace_fw_cfg_read' [-Werror=nested-externs] > >>> hw/fw_cfg.c: In function 'fw_cfg_add_file': > >>> hw/fw_cfg.c:460:13: error: implicit declaration of function > >>> trace_fw_cfg_add_file_dupe' [-Werror=implicit-function-declaration] > >>> hw/fw_cfg.c:460:13: error: nested extern declaration of > >>> trace_fw_cfg_add_file_dupe' [-Werror=nested-externs] > >>> hw/fw_cfg.c:467:5: error: implicit declaration of function > >>> trace_fw_cfg_add_file' [-Werror=implicit-function-declaration] > >>> hw/fw_cfg.c:467:5: error: nested extern declaration of > >>> trace_fw_cfg_add_file' [-Werror=nested-externs] > >>> cc1: all warnings being treated as errors > >>> make: *** [hw/fw_cfg.o] Error 1 > >> > >> Compiles fine for me. > >> > >> What happens if you blow away your build tree and start over? > >> > >> In my experience, rebuilding of trace-related stuff is rather fragile... > > > > There were some recent changes ... there's probably a stale trace.h and > > trace.c in the build directory. > > removing trace.c and trace.h is not enough, but a fresh clone of the > repository works. are there any more such files?
If you hit other issues you can avoid them using a build directory: $ mkdir build $ cd build $ path/to/qemu/configure ... $ make It places all generated files and build products into this directory. Simply 'rm -rf build' to start from a clean slate. Stefan