[Qemu-devel] [PATCH v9 2/4] use uimage_reset to reload uImage

[Olivia Yin]

Signed-off-by: Olivia Yin <hong-hua....@freescale.com>
---
 hw/loader.c |   57 +++++++++++++++++++++++++++++++++++++++++++++------------
 hw/loader.h |    6 ++++++
 2 files changed, 51 insertions(+), 12 deletions(-)

diff --git a/hw/loader.c b/hw/loader.c
index 4fa9965..89ce853 100644
--- a/hw/loader.c
+++ b/hw/loader.c
@@ -458,15 +458,15 @@ static ssize_t gunzip(void *dst, size_t dstlen, uint8_t 
*src,
     return dstbytes;
 }
 
-/* Load a U-Boot image.  */
-int load_uimage(const char *filename, hwaddr *ep,
-                hwaddr *loadaddr, int *is_linux)
+/* write uimage into memory */
+static int uimage_physical_loader(const char *filename, hwaddr *ep, 
+                                  uint8_t **data, hwaddr *loadaddr,
+                                  int *is_linux, int reset)
 {
     int fd;
     int size;
     uboot_image_header_t h;
     uboot_image_header_t *hdr = &h;
-    uint8_t *data = NULL;
     int ret = -1;
 
     fd = open(filename, O_RDONLY | O_BINARY);
@@ -508,9 +508,9 @@ int load_uimage(const char *filename, hwaddr *ep,
     }
 
     *ep = hdr->ih_ep;
-    data = g_malloc(hdr->ih_size);
+    *data = g_malloc(hdr->ih_size);
 
-    if (read(fd, data, hdr->ih_size) != hdr->ih_size) {
+    if (read(fd, *data, hdr->ih_size) != hdr->ih_size) {
         fprintf(stderr, "Error reading file\n");
         goto out;
     }
@@ -520,11 +520,11 @@ int load_uimage(const char *filename, hwaddr *ep,
         size_t max_bytes;
         ssize_t bytes;
 
-        compressed_data = data;
+        compressed_data = *data;
         max_bytes = UBOOT_MAX_GUNZIP_BYTES;
-        data = g_malloc(max_bytes);
+        *data = g_malloc(max_bytes);
 
-        bytes = gunzip(data, max_bytes, compressed_data, hdr->ih_size);
+        bytes = gunzip(*data, max_bytes, compressed_data, hdr->ih_size);
         g_free(compressed_data);
         if (bytes < 0) {
             fprintf(stderr, "Unable to decompress gzipped image!\n");
@@ -533,7 +533,11 @@ int load_uimage(const char *filename, hwaddr *ep,
         hdr->ih_size = bytes;
     }
 
-    rom_add_blob_fixed(filename, data, hdr->ih_size, hdr->ih_load);
+    if (!reset) {
+        rom_add_blob_fixed(filename, *data, hdr->ih_size, hdr->ih_load);
+    } else {
+        cpu_physical_memory_write(hdr->ih_load, *data, hdr->ih_size);
+    }
 
     if (loadaddr)
         *loadaddr = hdr->ih_load;
@@ -541,12 +545,41 @@ int load_uimage(const char *filename, hwaddr *ep,
     ret = hdr->ih_size;
 
 out:
-    if (data)
-        g_free(data);
     close(fd);
     return ret;
 }
 
+static void uimage_reset(void *opaque)
+{
+    UImageFile *img = opaque;
+    uint8_t *data = NULL;
+
+    uimage_physical_loader(img->image.name, img->ep, &data, 
&img->image.loadaddr, img->is_linux, 1);
+    g_free(data);
+}
+
+/* Load a U-Boot image.  */
+int load_uimage(const char *filename, hwaddr *ep,
+                hwaddr *loadaddr, int *is_linux)
+{
+    int size;
+    UImageFile *img;
+    uint8_t *data = NULL;
+
+    size = uimage_physical_loader(filename, ep, &data, loadaddr, is_linux, 0);
+    if (size > 0) {
+        g_free(data);
+        img = g_malloc0(sizeof(*img));
+        img->image.name = g_strdup(filename);
+        img->image.loadaddr = *loadaddr;
+        img->image.size = size;
+        img->ep = ep;
+        img->is_linux = is_linux;
+        qemu_register_reset(uimage_reset, img);
+    }
+    return size;
+}
+
 /*
  * Functions for reboot-persistent memory regions.
  *  - used for vga bios and option roms.
diff --git a/hw/loader.h b/hw/loader.h
index 29f52ab..b22d77b 100644
--- a/hw/loader.h
+++ b/hw/loader.h
@@ -7,6 +7,12 @@ typedef struct ImageFile {
     ssize_t size;
 } ImageFile;
 
+typedef struct UImageFile {
+    ImageFile image;
+    hwaddr *ep;
+    int *is_linux;
+} UImageFile;
+
 /* loader.c */
 int get_image_size(const char *filename);
 int load_image(const char *filename, uint8_t *addr); /* deprecated */
-- 
1.7.1