mdroth <mdr...@linux.vnet.ibm.com> writes:

> On Fri, Jan 11, 2013 at 11:25:02AM +0100, Markus Armbruster wrote:
>> We detect errors in seven places.  One reports with g_error(), which
>
> Do you mean "in several places"? I can fix this in tree.

I counted seven places, but it doesn't really matter, "several" would be
fine, too.

>> calls abort(), the others report with g_critical().  Three of them
>> exit(), three return false.
>> 
>> Always report with g_critical(), and return false.
>> 
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>
> Reviewed-by: Michael Roth <mdr...@linux.vnet.ibm.com>

Thanks!

Reply via email to