> On Sat, Jan 12, 2013 at 06:35:12PM +0100, Paolo Bonzini wrote: > > @@ -2566,6 +2755,22 @@ int main(int argc, char **argv, char **envp) > > > > module_call_init(MODULE_INIT_QOM); > > > > + qemu_add_opts(&qemu_drive_opts); > > + qemu_add_opts(&qemu_chardev_opts); > > + qemu_add_opts(&qemu_device_opts); > > + qemu_add_opts(&qemu_netdev_opts); > > + qemu_add_opts(&qemu_net_opts); > > + qemu_add_opts(&qemu_rtc_opts); > > + qemu_add_opts(&qemu_global_opts); > > + qemu_add_opts(&qemu_mon_opts); > > + qemu_add_opts(&qemu_trace_opts); > > + qemu_add_opts(&qemu_option_rom_opts); > > + qemu_add_opts(&qemu_machine_opts); > > + qemu_add_opts(&qemu_boot_opts); > > + qemu_add_opts(&qemu_sandbox_opts); > > + qemu_add_opts(&qemu_add_fd_opts); > > + qemu_add_opts(&qemu_object_opts); > > + > > Is there a reason to register in main() instead of using module init > functions? IMO it's preferrable to keep options modular instead of > making them global and registering in main().
I wasn't really sure where to put these. In some cases, such as drive_opts or trace_opts, those files are linked to tools that have nothing to do QemuOpts. In others, vl.c is really the consumer. The choice is between module_init in vl.c or qemu_add_opts as above. Paolo
