Am 04.01.2013 09:16, schrieb Gerd Hoffmann: > Also some QOM glue while being at it. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > hw/debugcon.c | 31 ++++++++++++++++++++++++------- > 1 files changed, 24 insertions(+), 7 deletions(-) > > diff --git a/hw/debugcon.c b/hw/debugcon.c > index 14f83f1..e8a855e 100644 > --- a/hw/debugcon.c > +++ b/hw/debugcon.c > @@ -29,20 +29,27 @@ > #include "isa.h" > #include "pc.h" > > +#define TYPE_ISA_DEBUGCON_DEVICE "isa-debugcon" > +#define ISA_DEBUGCON_DEVICE(obj) \ > + OBJECT_CHECK(ISADebugconState, (obj), TYPE_ISA_DEBUGCON_DEVICE)
Note that my previous QOM'ification RFC used the more verbose [TYPE_]ISA_DEBUG_CONSOLE to avoid the "debugcon" abbreviation. Care to cleanup? Otherwise looks good, thanks, and would've got a Reviewed-by had you not rushed to send a PULL. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
