On Thu, Dec 13, 2012 at 02:31:53PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > > > Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 > > 08:35:15 -0600) > > > > are available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony > > > > for you to fetch changes up to 5c1ad98d71923b83a530e5db4c2110564b84e11d: > > > > pci_bus.h: tweak include guards (2012-12-12 23:41:04 +0200) > > Doesn't build: > > CC hw/apm.o > /home/anthony/git/qemu/hw/apm.c:25:17: fatal error: pci.h: No such file or > directory > compilation terminated. > > And there's really no good reason for this. apm's part of target-i386 > so you couldn't have built this prior to doing a pull request. > > Please setup your tree in buildbot and wait for a full run before > sending a pull requests in the future. > > Regards, > > Anthony Liguori
Ugh. I'm not sure but I think I see how this happened: I re-run make after each commit, before the last one apm.c did find the header it depends on, the last commit only removes the -I flag to find the header but neither the header itself not the C file changed so it didn't need to rebuild. -- MST
