Il 14/12/2012 13:36, Juan Quintela ha scritto:
>>>> >>> - vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
>>>> >>> + if (old_vm_running) {
>>>> >>> + vm_stop(RUN_STATE_FINISH_MIGRATE);
>>>> >>> + } else {
>>>> >>> + vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
>>>> >>> + }
>>>> >>>
>>>> >>> if (qemu_savevm_state_complete(s->file) < 0) {
>>>> >>> migrate_fd_error(s);
>> >
>> > This hunk also seems to be useless nowadays.
> it is needed for when we are migrating in suspended state.
That was the case when the line read
vm_stop(RUN_STATE_FINISH_MIGRATE);
but it reads vm_stop_force_state. So you're being kind and not forcing
the change if running, but that's not necessary. Just always using
vm_stop_force_state works now, and would work with the migration thread too.
Paolo
