Alexander Graf <ag...@suse.de> writes:
> On 22.11.2012, at 15:16, Markus Armbruster wrote:
>
>> pci_drive_hot_add() parameter type has the wrong type: int instead of
>> BlockInterfaceType. It's actually redundant, so we can just drop it.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> hw/device-hotplug.c | 11 ++++-------
>> hw/pci-hotplug.c | 7 +++----
>> sysemu.h | 3 +--
>> 3 files changed, 8 insertions(+), 13 deletions(-)
>>
>> diff --git a/hw/device-hotplug.c b/hw/device-hotplug.c
>> index eec0fe3..6d9c080 100644
>> --- a/hw/device-hotplug.c
>> +++ b/hw/device-hotplug.c
>> @@ -49,18 +49,16 @@ DriveInfo *add_init_drive(const char *optstr)
>> }
>>
>> #if !defined(TARGET_I386)
>> -int pci_drive_hot_add(Monitor *mon, const QDict *qdict,
>> - DriveInfo *dinfo, int type)
>> +int pci_drive_hot_add(Monitor *mon, const QDict *qdict, DriveInfo *dinfo)
>> {
>> /* On non-x86 we don't do PCI hotplug */
>> - monitor_printf(mon, "Can't hot-add drive to type %d\n", type);
>> + monitor_printf(mon, "Can't hot-add drive to type %d\n", dinfo->type);
>
> Can't we expose names instead? I don't really want internal enum
> numbering be part of our external CLI interface :)
Fixing that would be nice, but it's outside this patch's scope.
