On Tue, Nov 20, 2012 at 06:54:20AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote: > > > Currently, the pseries machine initializes the cpus, then the XICS > > > interrupt controller. However, to support the upcoming in-kernel XICS > > > implementation we will need to initialize the irq controller before the > > > vcpus. This patch makes the necesssary rearrangement. This means the > > > xics init code can no longer auto-detect the number of cpus ("interrupt > > > servers" in XICS terminology) and so we must pass that in explicitly from > > > the platform code. > > > > Does this still hold true with the new in-kernel interrupt controller > > workflow? > > We need to look into this. The in-kernel ICPs will still certainly be > created early along with the VCPUs, however we might be able to delay > the creation of the qemu emulation when not using the former.
I'd really prefer not to have two different initialization orders in qemu though. I think we'll want the ICP initialization first for CPU hotplug one day anyway. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson