Am 16.11.2012 08:44, schrieb Paolo Bonzini:
Il 15/11/2012 19:28, Peter Lieven ha scritto:
I dont know if we should switch to use synchronous code here.
It is much nicer if all code is async.
bdrv_open is generally synchronous, so I think Peter's patch is ok.
if all is sync wouldn't it be best to have all code in iscsi_open sync
then and convert the iscsi_inquiry and iscsi_readcapacity commands also to
sync?
Indeed, there is no real advantage in using qemu_aio_wait(). I didn't
know libiscsi also had sync APIs. :)
ok, give me some days to rewrite this patch. i think it should be ready
by monday.
i will also add the missing iscsi_create which is a few lines only then.
peter
Paolo