Am 13.11.2012 18:31, schrieb Peter Maydell:
On 13 November 2012 08:42, Gerd Hoffmann <kra...@redhat.com> wrote:
This patch series fixes the build issues with the internal pixman
submodule. It also adds licensing info to the qemu-pixman.[ch] files.
These look OK (and I've tested that we can crosscompile using
internal pixman in a separate builddirectory).
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
One remaining problem it would be nice to fix (probably as a
separate patch given this lot is at the pullreq stage):
"make distclean" in qemu doesn't do a distclean in the pixman/
directory.
-- PMM
I just sent reviews for patches 1 and 2.
IMHO patch 2 needs some small corrections, and patch 1 can
optionally be improved.
With at least the corrections, you may add
Reviewed-by: Stefan Weil <s...@weilnetz.de>
The patch series clearly improves the current build code.
As Peter noted, more problems can be addressed later.
Cheers
Stefan
