On 10.11.2012 00:52, Peter Maydell wrote:
On 10 November 2012 00:45, Marek Vasut <ma...@denx.de> wrote:
Gerd Hoffmann wrote:
Question is just whenever we'll go silently fixup stuff in console.c or
use assert()s to enforce callers getting this correct. I'd tend to use
assert() as vmware-vga passing bogous stuff there IMHO indicates there
is a bug in vmware-vga.
Or rather some revisions of the guest X driver.
If qemu's vmware-vga is blithely trusting what the guest driver
hands it then that is itself a bug...
To answer Gerd's question, I think I'd go for clip rather than assert
(especially at this point in the release cycle), though I don't feel
very strongly about it.
I'd go for clipping rather than asserting too (no crash) in all layers
as a defensive approach (console.c/vnc.c). Additionally logging that
condition would be helpful that the arising bug (which occurred several
times with a lot of unapplied fixes) can be detected by users easily and
fixed accordingly.
Ciao,
Gerhard
