On 29 October 2012 09:54, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote: >> Rather than printing a message saying we're silently falling >> back to gthread coroutines when running on MacOS, actually >> do it silently. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> I guess this is a self-falsifying echo :-) >> >> configure | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/configure b/configure >> index 9f33c7d..e07baf3 100755 >> --- a/configure >> +++ b/configure >> @@ -2900,8 +2900,6 @@ EOF >> else >> coroutine_backend=gthread >> fi >> - else >> - echo "Silently falling back into gthread backend under darwin" >> fi > > Is there a reason to remove the echo?
1. Nothing else in configure prints progress messages during the testing phase 2. The echo is by definition printing something that's false 3. We print the chosen coroutine backend at the end as part of the standard "what did configure do?" output block, so removing this echo loses no information -- PMM
