Jocelyn Mayer wrote: > > On Wed, 2007-11-14 at 08:59 -0700, Thayne Harbaugh wrote: > > This patch, 44_target_posix_types.patch provides target specific posix > > types. These types improve target structure creation, code similarity > > to kernel code and improve type casting for assignment between target > > and host. > > Hi, > > This seems not OK for ppc/ppc64. There is no ppc64 subdirectory anymore > in the linux-user directory. ppc and ppc64 targets have been merged, as > it is in recent kernels, so all the definitions should go in the ppc > subdirectory, using #ifdef TARGET_PPC64 when there are differences; but > there should be very few: there are only 2 ifdef __powerpc64__ in the > linux-2.6.23/include/asm-powerpc/posix_types.h file.
I figure some conditionals went missing, on 32-bit Linux/ppc it fails to compile. Thiemo [...] gcc-3.4 -Wall -O2 -g -fno-strict-aliasing -fno-reorder-blocks -fno-gcse -fno-optimize-sibling-calls -fno-crossjumping -fno-align-labels -fno-align-jumps -fno-align-functions -I. -I.. -I/home/ths/qemu/qemu-write/target-ppc -I/home/ths/qemu/qemu-write -MMD -MP -DNEED_CPU_H -I/home/ths/qemu/qemu-write/linux-user -I/home/ths/qemu/qemu-write/linux-user/ppc -D__powerpc__ -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/home/ths/qemu/qemu-write/fpu -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/ths/qemu/qemu-write/slirp -c -o op.o /home/ths/qemu/qemu-write/target-ppc/op.c In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:30: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr0': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr0': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:33: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr1': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr1': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:36: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr2': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr2': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:39: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr3': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr3': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:42: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr4': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr4': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:45: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr5': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr5': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:48: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr6': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr6': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:51: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr7': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr7': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:54: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr8': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr8': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:57: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr9': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr9': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:60: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr10': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr10': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:63: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr11': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr11': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:66: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr12': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr12': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:69: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr13': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr13': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:72: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr14': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr14': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:75: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr15': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr15': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:78: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr16': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr16': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:81: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr17': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr17': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:84: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr18': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr18': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:87: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr19': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr19': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:90: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr20': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr20': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:93: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr21': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr21': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:96: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr22': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr22': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:99: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr23': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr23': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:102: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr24': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr24': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:105: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr25': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr25': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:108: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr26': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr26': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:111: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr27': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr27': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:114: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr28': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr28': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:117: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr29': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr29': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:120: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr30': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr30': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type In file included from /home/ths/qemu/qemu-write/target-ppc/op.c:123: /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T0_gpr64_gpr31': /home/ths/qemu/qemu-write/target-ppc/op_template.h:85: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op_template.h: In function `op_store_T1_gpr64_gpr31': /home/ths/qemu/qemu-write/target-ppc/op_template.h:92: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_splatw_T1_64': /home/ths/qemu/qemu-write/target-ppc/op.c:2726: warning: left shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_sli32_T1_64': /home/ths/qemu/qemu-write/target-ppc/op.c:2760: warning: left shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_srli32_T1_64': /home/ths/qemu/qemu-write/target-ppc/op.c:2766: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_evextsh': /home/ths/qemu/qemu-write/target-ppc/op.c:2802: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_evextsb': /home/ths/qemu/qemu-write/target-ppc/op.c:2809: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_evmergelo': /home/ths/qemu/qemu-write/target-ppc/op.c:2912: warning: left shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_evmergehi': /home/ths/qemu/qemu-write/target-ppc/op.c:2918: warning: right shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c: In function `op_evmergelohi': /home/ths/qemu/qemu-write/target-ppc/op.c:2924: warning: left shift count >= width of type /home/ths/qemu/qemu-write/target-ppc/op.c:2924: warning: right shift count >= width of type ../dyngen -o op.h op.o dyngen: empty code for op_efdnabs make[1]: *** [op.h] Error 1 make[1]: Leaving directory `/home/ths/qemu/qemu-write/ppc-linux-user' make: *** [subdir-ppc-linux-user] Error 2
