Le lundi 12 novembre 2007 à 18:23 +0200, Blue Swirl a écrit : > On 11/12/07, Laurent Vivier <[EMAIL PROTECTED]> wrote: > > > > It appears that fd_filename and snapshot are not needed/used by machine > > init functions (QEMUMachineInitFunc). > > > > This patch removes them. > > I don't know what was the idea for these parameters, so I can't > comment on the correctness of the patch in general.
fd_filename cannot be managed because I suppressed the array in vl.c
and Fabrice (when he commented the first revision of this patch)
proposed to remove "snapshot" too:
"- While modifying the machine init function, you can suppress the
snapshot parameter."
> > /* SPARCstation 5 hardware initialisation */
> > -static void ss5_init(int RAM_size, int vga_ram_size, const char
> > *boot_device,
> > - DisplayState *ds, const char **fd_filename, int
> > snapshot,
> > +static void ss5_init(int RAM_size, int vga_ram_size,
> > + const char *boot_device, DisplayState *ds,
> > const char *kernel_filename, const char
> > *kernel_cmdline,
> > const char *initrd_filename, const char *cpu_model)
> > {
> > @@ -616,8 +616,8 @@ static void ss5_init(int RAM_size, int v
> > }
> >
> > /* SPARCstation 10 hardware initialisation */
> > -static void ss10_init(int RAM_size, int vga_ram_size, const char
> > *boot_device,
> > - DisplayState *ds, const char **fd_filename,
> > int snapshot,
> > +static void ss10_init(int RAM_size, int vga_ram_size,
> > + const char *boot_device, DisplayState *ds,
> > const char *kernel_filename, const char
> > *kernel_cmdline,
> > const char *initrd_filename, const char
> > *cpu_model)
>
> You didn't fix ss600mp_init, which was added yesterday.
Oops, sorry, I missed it.
Thank you for your comments,
Laurent
--
------------- [EMAIL PROTECTED] --------------
"In short: just say NO TO DRUGS and maybe you won't
end up like the Hurd people." -- Linus Torvald
signature.asc
Description: Ceci est une partie de message numériquement signée
