Am 22.10.2012 18:17, schrieb Michael S. Tsirkin: > On Mon, Oct 22, 2012 at 03:26:24PM +0200, Andreas Färber wrote: >> Am 19.10.2012 22:43, schrieb Jason Baron: >>> create mode 100644 hw/i21154.c >>> create mode 100644 hw/i21154.h >> >> Why is this creating a new file and not reusing dec_pci.c? We shouldn't >> have two parallel implementations of the same chip. > > Good point I missed this. There's a minor difference > wrt dec-21154-p2p-bridge in a couple of fields, > these could be set by properties. > Also dec_map_irq differs from the spec compliant > map function. I am guessing this is a bug. > Would appreciate testing of the patch below. > > > Are you familiar with dec_pci.c? Looking at it, it seems to > implement a pci host bridge "dec-21154-sysbus" , > a pci to pci bridge "dec-21154-p2p-bridge", > and something called "dec-21154" which sports a comment > "PCI2PCI bridge same values as PearPC - check this" - > and implements an empty init function; > what this last is and why it's useful I am not sure.
Apart from my PHB rework touching it, I had a branch starting to QOM'ify it. From what I remember it was a PCIDevice that interfaces with a "regular" SysBus PHB device and like most PHBs has a PCIDevice on its PCIBus. That would match the number of devices you mention, although the exact names are pretty confusing for all PHBs IMO. ;) > Anyone? Blue Swirl? Anyone can test this doesn't break > things and report? I'll look more closely and test when I'm back from oSC mid of the week. I think it was ppc_newworld that was using this, possibly subject to #if 0 (which I was trying to clean up, too). Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
