Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: >> I suggest that you implement the commands in a similar way as netdev_add. > > Why? Isn't the whole point of using josn is that you'll get the stuff > from the josn parser & marshaller in a usable form instead of having it > to feed into yet another parser? I think the only reason netdev_add > exists in the current form is that it predates qmp.
In principle you're right, but I think it's ugly that adding another chardev argument needs changes in 3 places instead of just one. (And I'd like to add another argument soon enough...). Paolo