Il 11/10/2012 15:14, Eric Blake ha scritto: >>>> +## >>>> +# @nbd-server-add: >>>> +# >>>> +# Export a device to QEMU's embedded NBD server. >>>> +# >>>> +# @device: Block device to be exported >>>> +# >>>> +# @writable: Whether clients should be able to write to the device via the >>>> +# NBD connection (default false). #optional >>> >>> Isn't the #optional designation supposed to come first, before 'Whether'? >> >> Does it really matter with no program yet written to consume it? >> Putting it at the end matches the old qmp-commands.hx format better (for >> commands that do have qmp-commands.hx documentation). > > I'm just asking on the grounds of consistency based on observation, and > not based on an actual hard requirement of something that goes wrong if > it's out of order. Therefore, I'm okay with your explanation, as long > as no one else can provide hard evidence for a mandatory positioning of > the marker.
In fact, if such a program existed, it would be able to derive the optional-ness of the argument from the schema, and it would make sense for consistency to eliminate all #optional markers... Paolo
