On 10/09/2012 01:27 PM, Aurelien Jarno wrote: > + tcg_gen_setcondi_tl(TCG_COND_EQ, t2, t0, INT_MIN); > + tcg_gen_setcondi_tl(TCG_COND_EQ, t3, t1, -1); > + tcg_gen_and_tl(t2, t2, t3); > + tcg_gen_setcondi_tl(TCG_COND_EQ, t3, t1, 0); > + tcg_gen_or_tl(t2, t2, t3); > + tcg_gen_movi_tl(t3, 1); > + tcg_gen_movcond_tl(TCG_COND_NE, t1, t2, t4, t3, t1);
You don't need t3. tcg_gen_movcond_tl(TCG_COND_NE, t1, t2, t4, t2, t1); I.e. if true, t2 already contains 1. That said, the patch isn't incorrect. Reviewed-by: Richard Henderson <r...@twiddle.net> r~